Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3373] Add e2e multi item select method in DataTable component #6129

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

rdiacenco
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe: Extend e2e testing framework

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #6129 into develop will increase coverage by 3.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6129      +/-   ##
===========================================
+ Coverage    75.35%   78.77%   +3.41%     
===========================================
  Files          624      371     -253     
  Lines        14849     8269    -6580     
  Branches      3119     1491    -1628     
===========================================
- Hits         11190     6514    -4676     
+ Misses        2718     1284    -1434     
+ Partials       941      471     -470     
Impacted Files Coverage Δ
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (-1.97%) ⬇️
lib/core/toolbar/toolbar-divider.component.ts
lib/core/services/people-process.service.ts
lib/core/services/discovery-api.service.ts
...lib/process/directives/process-directive.module.ts
lib/core/services/version-compatibility.service.ts
lib/core/login/models/login-success.event.ts
lib/core/info-drawer/info-drawer.component.ts
lib/core/models/identity-role.model.ts
lib/core/viewer/components/txt-viewer.component.ts
... and 701 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472e112...92eed2a. Read the comment docs.

@rdiacenco rdiacenco force-pushed the dev-rdiacenco-ACA-3373-2 branch from 756f3db to aa6f26c Compare September 18, 2020 06:08
@rdiacenco rdiacenco force-pushed the dev-rdiacenco-ACA-3373-2 branch from aa6f26c to 6b75d58 Compare September 18, 2020 07:37
@rdiacenco rdiacenco force-pushed the dev-rdiacenco-ACA-3373-2 branch 2 times, most recently from ab9de72 to 92eed2a Compare September 22, 2020 21:21
@codecov-io
Copy link

Codecov Report

Merging #6129 into develop will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6129      +/-   ##
===========================================
+ Coverage    78.47%   78.77%   +0.30%     
===========================================
  Files          489      371     -118     
  Lines        11455     8269    -3186     
  Branches      2175     1491     -684     
===========================================
- Hits          8989     6514    -2475     
+ Misses        1787     1284     -503     
+ Partials       679      471     -208     
Impacted Files Coverage Δ
...tent-widget/attach-file-widget-dialog.component.ts 77.77% <0.00%> (-4.37%) ⬇️
...s/search-date-range/search-date-range.component.ts 60.52% <0.00%> (-3.12%) ⬇️
.../src/lib/site-dropdown/sites-dropdown.component.ts 88.13% <0.00%> (-1.70%) ⬇️
...omponents/search-filter/search-filter.component.ts 73.52% <0.00%> (-0.16%) ⬇️
...ib/process-services/src/lib/form/form.component.ts 86.42% <0.00%> (-0.10%) ⬇️
...b/content-services/src/lib/search/search.module.ts 100.00% <0.00%> (ø)
...ices/src/lib/document-list/document-list.module.ts 100.00% <0.00%> (ø)
...ces/src/lib/search/search-query-builder.service.ts 75.00% <0.00%> (ø)
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (ø)
...tent-node-selector/content-node-selector.module.ts 100.00% <0.00%> (ø)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c134ec...4e1190a. Read the comment docs.

* Remove one line methods
* Fix datatable-component and e2e test
* Fix standalone-task-e2e test
@popovicsandras popovicsandras merged commit f918d9e into develop Nov 6, 2020
@popovicsandras popovicsandras deleted the dev-rdiacenco-ACA-3373-2 branch November 6, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants