Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5165] - added involved user for task #5985

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/ADF-5165

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vito Albano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #5985 into develop will increase coverage by 2.70%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5985      +/-   ##
===========================================
+ Coverage    75.90%   78.61%   +2.70%     
===========================================
  Files          703      233     -470     
  Lines        14802     6410    -8392     
  Branches      2917     1259    -1658     
===========================================
- Hits         11236     5039    -6197     
+ Misses        2701      995    -1706     
+ Partials       865      376     -489     
Impacted Files Coverage Δ
...k-list/components/task-form/task-form.component.ts 90.32% <87.50%> (-0.38%) ⬇️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
lib/extensions/src/test.ts
...ib/core/search-text/search-text-input.component.ts
...mponents/widgets/dropdown/dropdown-cloud.widget.ts
...rc/lib/task/task-list/models/filter-cloud-model.ts
...components/events/diagram-start-event.component.ts
...components/raphael/raphael-flow-arrow.component.ts
lib/core/sorting-picker/sorting-picker.module.ts
lib/core/services/identity-role.service.ts
... and 746 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0aaf0e...efcb2de. Read the comment docs.

@eromano eromano merged commit 9ec04d3 into develop Aug 13, 2020
@eromano eromano deleted the dev-valbano-ADF-5165 branch August 13, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants