Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5165] [Regression] Fix Checkbok widget in completed tasks #5979

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Aug 12, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-5165
Checkbox widgets were all checked when the task was completed.

What is the new behaviour?
It happened because the widget type changes from boolean to readonly. It's been fixed to represent the real value.
Screen Shot 2020-08-12 at 12 47 10

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020

Codecov Report

Merging #5979 into develop will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5979      +/-   ##
===========================================
+ Coverage    76.41%   76.69%   +0.27%     
===========================================
  Files          845      836       -9     
  Lines        18723    18465     -258     
  Branches      3697     3630      -67     
===========================================
- Hits         14308    14161     -147     
+ Misses        3299     3199     -100     
+ Partials      1116     1105      -11     
Impacted Files Coverage Δ
...e/form/components/widgets/core/form-field.model.ts 89.26% <100.00%> (+0.05%) ⬆️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
lib/core/services/upload.service.ts 84.39% <0.00%> (-4.05%) ⬇️
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (-1.97%) ⬇️
lib/extensions/src/lib/config/extension-utils.ts
...sions/src/lib/services/extension-loader.service.ts
lib/extensions/src/lib/services/rule.service.ts
...ons/src/lib/services/component-register.service.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
.../components/dynamic-component/dynamic.component.ts
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0aaf0e...bf6891b. Read the comment docs.

@eromano eromano merged commit 9b3efb5 into develop Aug 12, 2020
@eromano eromano deleted the dev-dcano-ADF-5165 branch August 12, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants