Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3219] Start process button is disabled when page is first displayed #5955

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

mcchrys
Copy link
Contributor

@mcchrys mcchrys commented Aug 5, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3219

The generateProcessInstance() is called before the default processInstanceName is set.

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #5955 into develop will increase coverage by 2.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5955      +/-   ##
===========================================
+ Coverage    76.08%   78.40%   +2.32%     
===========================================
  Files          843      334     -509     
  Lines        18764     8947    -9817     
  Branches      3690     1779    -1911     
===========================================
- Hits         14276     7015    -7261     
+ Misses        3374     1384    -1990     
+ Partials      1114      548     -566     
Impacted Files Coverage Δ
...rocess/components/start-process-cloud.component.ts 85.29% <ø> (+4.41%) ⬆️
...ib/document-list/services/document-list.service.ts 74.50% <0.00%> (-1.97%) ⬇️
.../form/components/widgets/content/content.widget.ts
.../core/dialogs/edit-json/edit-json.dialog.module.ts
lib/core/services/comment-content.service.ts
lib/core/pipes/multi-value.pipe.ts
lib/core/services/download.service.ts
...ts/src/lib/diagram/models/chart/pie-chart.model.ts
.../form/components/widgets/unknown/unknown.widget.ts
lib/core/directives/directive.module.ts
... and 507 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e8a5d...8d404f5. Read the comment docs.

@DenysVuika DenysVuika merged commit 700c065 into develop Aug 5, 2020
@DenysVuika DenysVuika deleted the dev-mrc-aca-3219 branch August 5, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants