Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5210] Order by folder on default #5945

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Aug 3, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Order by cm type makes Sites that is type cm:sites always on the top

What is the new behaviour?
Order by folder on default

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #5945 into develop will increase coverage by 1.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5945      +/-   ##
===========================================
+ Coverage    76.07%   77.64%   +1.56%     
===========================================
  Files          843      243     -600     
  Lines        18763     6463   -12300     
  Branches      3690     1309    -2381     
===========================================
- Hits         14274     5018    -9256     
+ Misses        3375     1019    -2356     
+ Partials      1114      426     -688     
Impacted Files Coverage Δ
...ocument-list/components/document-list.component.ts 80.31% <100.00%> (ø)
...product-version/about-product-version.component.ts
...b/core/mock/form/widget-visibility.service.mock.ts
lib/core/mock/app-config.service.mock.ts
lib/core/services/storage.service.ts
...ib/core/search-text/search-text-input.component.ts
...am/components/tooltip/diagram-tooltip.component.ts
...am/components/swimlanes/diagram-pools.component.ts
lib/core/services/translation.service.ts
...ces/src/lib/task-list/models/task-details.model.ts
... and 592 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85183ea...76579b7. Read the comment docs.

@eromano eromano merged commit c66ad49 into develop Aug 3, 2020
@eromano eromano deleted the dev-eromano-ADF-5210 branch August 3, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants