Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3804] Add All option in process definition name filter dropdown #5937

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

mcchrys
Copy link
Contributor

@mcchrys mcchrys commented Jul 31, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3804

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #5937 into develop will increase coverage by 2.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5937      +/-   ##
===========================================
+ Coverage    76.08%   78.14%   +2.06%     
===========================================
  Files          843      334     -509     
  Lines        18739     8940    -9799     
  Branches      3683     1778    -1905     
===========================================
- Hits         14257     6986    -7271     
+ Misses        3374     1405    -1969     
+ Partials      1108      549     -559     
Impacted Files Coverage Δ
.../components/edit-process-filter-cloud.component.ts 73.54% <100.00%> (+0.42%) ⬆️
.../lib/task-list/components/attach-form.component.ts 35.89% <0.00%> (-15.39%) ⬇️
.../lib/search/search-header-query-builder.service.ts 76.92% <0.00%> (-6.42%) ⬇️
...vices/src/lib/search/base-query-builder.service.ts 85.82% <0.00%> (-0.55%) ⬇️
.../attach-file/attach-file-cloud-widget.component.ts 94.11% <0.00%> (ø)
...nents/raphael/icons/raphael-icon-user.component.ts
lib/core/language-menu/language-menu.module.ts
...am/components/activities/diagram-task.component.ts
...server-settings/about-server-settings.component.ts
lib/extensions/src/test.ts
... and 510 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d553c71...d4649d1. Read the comment docs.

@popovicsandras popovicsandras merged commit 5f5bedd into develop Aug 4, 2020
@popovicsandras popovicsandras deleted the dev-mrc-aca-3804 branch August 4, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants