Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused ID and fix the duplicate warning #5933

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

if the component is used multiple times, the non-unique "ID" clashes at runtime

Screenshot 2020-07-30 at 12 33 24

What is the new behaviour?

  • remove the ID (not used anywhere)
  • fix the Chrome/Edge warnings on the duplicate ID

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #5933 into develop will increase coverage by 2.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5933      +/-   ##
===========================================
+ Coverage    76.11%   78.27%   +2.16%     
===========================================
  Files          843      334     -509     
  Lines        18748     8927    -9821     
  Branches      3690     1779    -1911     
===========================================
- Hits         14270     6988    -7282     
+ Misses        3363     1386    -1977     
+ Partials      1115      553     -562     
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
lib/extensions/src/lib/config/extension-utils.ts
lib/core/utils/object-utils.ts
lib/core/pipes/user-initial.pipe.ts
...s/card-view-mapitem/card-view-mapitem.component.ts
lib/core/services/lock.service.ts
...b/diagram/models/report/report-parameters.model.ts
lib/core/services/people-process.service.ts
...able/components/empty-list/empty-list.component.ts
...gets/dynamic-table/editors/amount/amount.editor.ts
... and 500 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dde977...c21f1ea. Read the comment docs.

@eromano eromano merged commit 0afbe36 into develop Jul 30, 2020
@eromano eromano deleted the remove-useless-id branch July 30, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants