Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3731] E2E test to validate Save, Save as and Delete buttons availability on custom filters #5929

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

bogdanapatrichi
Copy link
Contributor

  • Add createNewCustomFilter() method in edit-task-filters-component.e2e.ts

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe: E2E test for Delete, Save and Save as actions that should be displayed and enabled when clicking on custom filter header

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…lability on custom filters

* Add createNewCustomFilter() method in edit-task-filters-component.e2e.ts
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2020

Codecov Report

Merging #5929 into develop will increase coverage by 2.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5929      +/-   ##
===========================================
+ Coverage    76.06%   78.22%   +2.15%     
===========================================
  Files          843      142     -701     
  Lines        18726     3885   -14841     
  Branches      3684      773    -2911     
===========================================
- Hits         14244     3039   -11205     
+ Misses        3361      598    -2763     
+ Partials      1121      248     -873     
Impacted Files Coverage Δ
.../lib/upload/directives/file-draggable.directive.ts 32.65% <0.00%> (-1.39%) ⬇️
...src/lib/task/start-task/start-task-cloud.module.ts
...vices/src/lib/task-list/models/start-task.model.ts
.../core/card-view/models/card-view-boolitem.model.ts
...hael/icons/raphael-icon-business-rule.component.ts
...ram/components/swimlanes/diagram-pool.component.ts
lib/core/form/services/form.service.ts
...onents/icons/diagram-icon-script-task.component.ts
...lib/task/task-filters/models/filter-cloud.model.ts
lib/core/mock/bpm-user.service.mock.ts
... and 692 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bf60e...ae0ab54. Read the comment docs.

@eromano eromano merged commit e987fba into develop Jul 30, 2020
@eromano eromano deleted the dev-petra-aca-3731 branch July 30, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants