Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3678] Disable Save and Delete Button for Default Filters #5928

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

mcchrys
Copy link
Contributor

@mcchrys mcchrys commented Jul 29, 2020

  • Added unit tests

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe: Unit tests added

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #5928 into develop will increase coverage by 2.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5928      +/-   ##
===========================================
+ Coverage    76.07%   78.62%   +2.54%     
===========================================
  Files          843      233     -610     
  Lines        18763     6394   -12369     
  Branches      3690     1248    -2442     
===========================================
- Hits         14274     5027    -9247     
+ Misses        3375      990    -2385     
+ Partials      1114      377     -737     
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 35.89% <0.00%> (-15.39%) ⬇️
...ponents/unknown-format/unknown-format.component.ts
lib/core/models/identity-role.model.ts
...yout/directives/sidenav-layout-header.directive.ts
...ghts/src/lib/mock/diagram/diagram-boundary.mock.ts
.../components/edit-process-filter-cloud.component.ts
...nents/icons/diagram-icon-service-task.component.ts
...re/form/components/form-custom-button.directive.ts
.../lib/diagram/components/raphael/raphael.service.ts
...src/lib/task/directives/complete-task.directive.ts
... and 601 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85183ea...9da1f24. Read the comment docs.

Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setTimeout should not be used in test neither necesary

sortOptions[3].nativeElement.click();
fixture.detectChanges();

setTimeout(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a setTimeout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@eromano eromano merged commit 1dec2ba into develop Aug 4, 2020
@eromano eromano deleted the dev-mrc-aca-3678 branch August 4, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants