[ACA-3672] - added server order for document -list #5899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitoAlbano
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
|
Vito Albano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## develop #5899 +/- ##
===========================================
+ Coverage 76.24% 76.53% +0.28%
===========================================
Files 839 830 -9
Lines 18632 18384 -248
Branches 3656 3590 -66
===========================================
- Hits 14206 14070 -136
+ Misses 3318 3218 -100
+ Partials 1108 1096 -12
Continue to review full report at Codecov.
|
eromano
requested changes
Jul 22, 2020
| } | ||
| } | ||
|
|
||
| private retrieveDocumentNode(nodeId: string, pagination: PaginationModel, includeFields: string[], where?: string): Observable<DocumentLoaderNode> { | ||
| private retrieveDocumentNode(nodeId: string, pagination: PaginationModel, includeFields: string[], where?: string, orderByValue?: string[]): Observable<DocumentLoaderNode> { |
There was a problem hiding this comment.
orderByValue can we rename it to orderBy ?
VitoAlbano
force-pushed
the
dev-valbano-ACA-3672
branch
from
4080d3d to
5cb64a8
Compare
eromano
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Document list apply only FE sorting
What is the new behaviour?
Document list apply FE or BE sorting
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://issues.alfresco.com/jira/browse/ACA-3672