[ADF-3484] - Metadata drop-down list option for properties constrained by a list of values #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pionnegru
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
eromano
requested changes
Jul 21, 2020
| } | ||
|
|
||
| return cardViewItemProperty; | ||
| } | ||
|
|
||
| private isListOfValues(constraint: Constraint[]): boolean { | ||
| return constraint && constraint[0] && constraint[0].type === 'LIST'; |
There was a problem hiding this comment.
can we use the optional Chaining?
| } | ||
|
|
||
| private getPropertyConstraints(propertyName: string, definition: Definition): Constraint[] | null { | ||
| const property = definition && definition.properties.find((item) => item.id === propertyName); |
There was a problem hiding this comment.
can we use the optional Chaining? and nullish coalescing?
eromano
approved these changes
Jul 21, 2020
mcchrys
pushed a commit
that referenced
this pull request
Jul 28, 2020
…d by a list of values (#5892) * update js-api * include definition field * process LIST constraint * update tests * dropdown visibility * optional chaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
ADF-3484
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: