Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-21595] Content - Expose a group service for content #5833

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mauriziovitale mauriziovitale changed the title Content - Expose a group service for content [MNT-21595] Content - Expose a group service for content Jul 2, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #5833 into develop will decrease coverage by 0.03%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5833      +/-   ##
===========================================
- Coverage    83.94%   83.90%   -0.04%     
===========================================
  Files          963      966       +3     
  Lines        27244    27259      +15     
  Branches      3799     3801       +2     
===========================================
+ Hits         22869    22871       +2     
- Misses        3237     3252      +15     
+ Partials      1138     1136       -2     
Impacted Files Coverage Δ
...ission-manager/services/node-permission.service.ts 93.58% <0.00%> (ø)
...t-services/src/lib/group/services/group.service.ts 33.33% <33.33%> (ø)
lib/core/services/alfresco-api.service.ts 86.20% <50.00%> (ø)
lib/content-services/src/lib/group/index.ts 100.00% <100.00%> (ø)
lib/content-services/src/lib/group/public-api.ts 100.00% <100.00%> (ø)
lib/content-services/src/public-api.ts 100.00% <100.00%> (ø)
lib/core/services/translate-loader.service.ts 72.15% <0.00%> (-8.87%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d56cd9...da4e2f5. Read the comment docs.

@mauriziovitale mauriziovitale force-pushed the mvitale-group-service branch from b31d741 to da4e2f5 Compare July 13, 2020 08:11
@DenysVuika DenysVuika merged commit 42d88fd into develop Jul 13, 2020
@DenysVuika DenysVuika deleted the mvitale-group-service branch July 13, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants