Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-2159] Update angular-cli to latest version #2874

Merged
merged 24 commits into from
Feb 1, 2018

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Jan 24, 2018

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
Update angular-cli to latest version 1.6.5

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@eromano eromano added this to the 2.1.0 milestone Jan 24, 2018
@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@dd7afc6). Click here to learn what that means.
The diff coverage is 64%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #2874   +/-   ##
==============================================
  Coverage               ?   90.65%           
==============================================
  Files                  ?      490           
  Lines                  ?    20457           
  Branches               ?     5157           
==============================================
  Hits                   ?    18546           
  Misses                 ?     1911           
  Partials               ?        0
Impacted Files Coverage Δ
...am/components/tooltip/diagram-tooltip.component.ts 83.78% <0%> (ø)
...-selector/content-node-selector-panel.component.ts 94.07% <100%> (ø)
...ib/core/userinfo/components/user-info.component.ts 98.57% <100%> (ø)
...services/site-dropdown/sites-dropdown.component.ts 100% <100%> (ø)
...ices/search/components/search-control.component.ts 94.73% <100%> (ø)
lib/core/viewer/components/viewer.component.ts 70.71% <62.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7afc6...b378d31. Read the comment docs.

@VitoAlbano VitoAlbano force-pushed the dev-eromano-ADF-2159 branch from f42b031 to b378d31 Compare January 31, 2018 17:40
@eromano eromano merged commit 9e4b2e7 into development Feb 1, 2018
@VitoAlbano VitoAlbano deleted the dev-eromano-ADF-2159 branch February 1, 2018 10:21
eromano added a commit that referenced this pull request Mar 5, 2018
* Update angular cli version 1.6.5

* fix tslint problems and update devdependencies using the angularcli 1.6.4

* test fixing

* [ADF-2159] start fixing userinfo test

* [ADF-2159] fixed userinfo tests

* [ADF-2159] added async to accordion component test

* [ADF-2159] testing probable failed test on CI

* [ADF-2159] check removing fake destroyed view test

* [ADF-2159] check viewer tests

* [ADF-2159] attempt on test fix

* [ADF-2159] test fix

* [ADF-2159] fix test

* [ADF-2159] fix test

* [ADF-2159] rebased

* [ADF-2159] check test

* [ADF-2159] fixing test

* [ADF-2159] Fix#1

* [ADF-2159] Fix#2

* [ADF-2159] Fix#3

* [ADF-2159] Fix #4

* [ADF-2159] Fix #5

* [ADF-2159] Fix #6

* [ADF-2159] fixed viewer test

* [ADF-2159] fixed cast element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants