Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4487] support search forms layout #2195

Merged
merged 6 commits into from
Jun 27, 2021
Merged

[ACA-4487] support search forms layout #2195

merged 6 commits into from
Jun 27, 2021

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Jun 25, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?
expansion layout replaced with chip based search layout

image
image

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

depends Alfresco/alfresco-ng2-components#7122

@pr-triage pr-triage bot added the PR: draft label Jun 25, 2021
@dhrn dhrn changed the title [ACA-4487] support search chips -initial commit [ACA-4487] support search forms layout Jun 25, 2021
Copy link
Contributor

@DenysVuika DenysVuika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but please check if we can cleanup some i18n/rule resources as well

@eromano eromano self-requested a review June 25, 2021 15:29
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixed the Denys comment

@dhrn dhrn force-pushed the dev-dhrn-ACA-4487 branch from 3ac233e to 0b20dea Compare June 26, 2021 19:02
@dhrn dhrn marked this pull request as ready for review June 27, 2021 05:36
@dhrn dhrn requested a review from DenysVuika June 27, 2021 06:47
@dhrn dhrn requested a review from adinapitul June 27, 2021 06:51
@eromano eromano merged commit 8a54b11 into develop Jun 27, 2021
@eromano eromano deleted the dev-dhrn-ACA-4487 branch June 27, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants