Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3115] Update ADF to the latest version #1563

Closed

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2020

CLA assistant check
All committers have signed the CLA.

@sivakumar414ram sivakumar414ram force-pushed the dev-siva-update-adf-version-to-fix-build branch from 46382fe to 003d02a Compare July 28, 2020 10:45
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1563 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1563   +/-   ##
========================================
  Coverage    69.04%   69.04%           
========================================
  Files          102      102           
  Lines         2756     2756           
  Branches       564      564           
========================================
  Hits          1903     1903           
  Misses         715      715           
  Partials       138      138           
Impacted Files Coverage Δ
src/app/services/node-actions.service.ts 84.33% <ø> (ø)
src/app/services/node-template.service.ts 94.44% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dff520...003d02a. Read the comment docs.

@sivakumar414ram
Copy link
Contributor Author

sivakumar414ram commented Jul 28, 2020

Closing this pr as we fixed problem at ADF side Alfresco/alfresco-ng2-components#5921

@eromano eromano deleted the dev-siva-update-adf-version-to-fix-build branch November 10, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants