Fix entity_id param parsing

[Jaypeg85]

Hi,

First off - I love this integration!! I use it to cast all my own custom angular dashboards around the house to smart mirrors (with chromecasts attached) and nest hubs.

Yesterday me DashCast integration stopped working. I now get errors in the log like this: AttributeError: 'AppleTvMediaPlayer' object has no attribute '_chromecast' although I'm casting to a chromecast mediaplayer and not an AppleTvMediaPlayer.

  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 526, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 764, in _async_call_service_step
    response_data = await self._async_run_long_action(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 727, in _async_run_long_action
    return await long_task
           ^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2802, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 2845, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/dash_cast/__init__.py", line 31, in play_media
    chromecast: Chromecast = getattr(entity, "_chromecast")

Any ideas to what is happening?

[AlexxIT]

Because this component only for Google Chromecast. And you trying to use it with AppleTV.

[Jaypeg85]

I get that it indeed looks like that, but as i stated this is not the case. I checked multiple times after seeing the log and tried many different nest hubs/chromecasts.
And the GUI in development tools/Action won't even let me choose anything other than the chromecast devices

[AlexxIT]

I know GUI should filter all media_players except Chromecast. I don't know how that can happen.

The media player search function is pretty simple. The comparison is based on entity_id.

DashCast/custom_components/dash_cast/__init__.py

Lines 25 to 31 in 997831a

	for entity in hass.data[DATA_INSTANCES]["media_player"].entities:
	if entity.entity_id not in entity_ids:
	continue
	dash: DashCastController = dashs.get(entity.entity_id)
	if not dash:
	chromecast: Chromecast = getattr(entity, "_chromecast")

Do you have AppleTV? Maybe it's entity_id similar to your chromecast. Or maybe it was similar by default and you have changed it manually?

[Jaypeg85]

Yea, I can't really figure that out... it stopped working after i readded my HomePods/AppleTVs because they were updated to iOS 18 and the AppleTV integration couldn't handle that apparently. So there have been tinkering with AppleTV's, but I haven't changed the automations where I use dashcast. I'm in the process of removing and readding all chromecasts, to see if that helps

[Jaypeg85]

Hmm... that didn't change anything. However when i disable the HomePods/AppleTVs it works again. It seems that the homepods named media_player.kids_room interferes with the media_player.kids_room_display for some reason

[AlexxIT]

I will check if this issue related to renaming entity_id.

[AlexxIT]

https://github.com/AlexxIT/DashCast/releases/tag/v1.1.1