Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file glob code #12

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

sjspielman
Copy link
Member

@sjspielman sjspielman commented Apr 24, 2024

This PR updates parsing to handle file globs better.

Noting that I tested this locally to see if we can grab all the OpenScPCA docs files, and it worked with "docs/* docs/*/* docs/*/*/*" to get all the nested docs levels. ** didn't change the behavior and all three arguments do seem to be needed.

After this goes in, we'll want to bump the release tag and update its usage in OpenScPCA-analysis accordingly.

@sjspielman sjspielman requested a review from jashapiro April 24, 2024 16:13
Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sad that ** expansion doesn't work, but I guess that is not strictly part of the POSIX standard, just something that a lot of implementations do.

spell-check.R Outdated Show resolved Hide resolved
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
@sjspielman sjspielman merged commit 205ea3e into AlexsLemonade:main Apr 24, 2024
1 check passed
@sjspielman sjspielman deleted the sjspielman/spellcheck-files branch April 24, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants