Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantification comparison, PR2 of 2: Plot mapper comparisons #45

Merged
merged 10 commits into from
Nov 5, 2020

Conversation

jashapiro
Copy link
Member

This PR adds a notebook with comparisons of various mapper options, looking at concordance with the "standard" of Cell Ranger.

This PR hopefully completes #9 and #2 (at least for now), working from the backbone of #35

⚠️Note: the target for this PR is #39 , but that should update to master once #39 is merged... that is part of what I am testing here: properly stacked PRs!

The easiest way to view the rendered notebooks is with htmlpreview: https://htmlpreview.github.io/?https://github.com/AlexsLemonade/alsf-scpca/blob/jashapiro/compare-quant-2-analysis/analysis/quantifier-comparisons/02-compare_quants.nb.html

Results summary

I am here copying with slight modification the comments that I left in #35:

The top line result is that the results from Alevin are much more in line with the Cell Ranger baseline than Kallisto's results. There is a subtle further improvement with the addition of decoys, but it is small.

As discussed earlier (#24 (comment)) Kallisto seems to consistently give somewhat higher expression values for lowly expressed genes; Alevin does this too relative to Cell Ranger (to a lesser extent), which leads me to suspect that this is a result of pseudomapping, which may be partially offset by Alevin's selective alignment. Cell Ranger may also be underestimating some genes if freagments are multimapped and discarded.

Note: while this analysis was done using cDNA transcripts only, I have no reason to suspect (partly based on results from #24) that using the full transcriptome would change the results at all. Indeed, #22 suggests that the full transcriptome is better, but I only ran Cellranger with cDNA, so I was limited to that comparison for this notebook.

Questions for Reviewers

Are the analyses presented here reasonable? Are there any glaring errors of logic or omission?

If there are new analyses you might suggest, we may want to add those as a separate issue for future analysis.

@jaclyn-taroni jaclyn-taroni self-requested a review November 3, 2020 14:56
Base automatically changed from jashapiro/compare-quant-1-import to master November 5, 2020 14:23
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to return my "this could be easier to read" review first.

analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor things! (And personal preferences, which for the most part I have refrained from leaving here – I prefer lots of inline comments in the code blocks because I think it makes life better for six-months-from-now-me.)

analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
@@ -0,0 +1,356 @@
---
title: "SCRNAseq quantification comparisons"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to add a : and something more descriptive like you have for the earlier notebook?

analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
analysis/quantifier-comparisons/02-compare_quants.Rmd Outdated Show resolved Hide resolved
jashapiro and others added 2 commits November 5, 2020 12:22
Co-authored-by: Jaclyn Taroni <jaclyn.n.taroni@gmail.com>
@jashapiro jashapiro merged commit 9e28b47 into master Nov 5, 2020
@jashapiro jashapiro mentioned this pull request Nov 6, 2020
@jashapiro jashapiro deleted the jashapiro/compare-quant-2-analysis branch October 22, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants