Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directory junction support #11

Open
wants to merge 16 commits into
base: msys2-master
Choose a base branch
from

Conversation

Karlson2k
Copy link

This PR add support for directory junction creation as symlink.
Directory junction is supported since Win2k and do not require admin rights or UAC disable.
With new default symlink setting autotools' configure will use ln -s for symlinks instead of cp -pR which can speedup a lot building in some situations.
Note: Cygwin already is able to read junction, this PR add only support for creation.
Upstream patch: https://cygwin.com/ml/cygwin-patches/2015-q3/msg00028.html

Alexpux and others added 16 commits September 10, 2015 14:26
…ent variables to Windows form for native Win32 applications.
…nings for DOS paths. - By default mount without ACLs. - Can read /etc/fstab with short mount point format.
With MSys1, it was necessary to set the TERM variable to "msys". To
allow for a smooth transition from MSys1 to MSys2, let's simply handle
TERM=msys as if the user had not specified TERM at all and wanted us to
use our preferred TERM value.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
strace is a Windows program so MSYS2 will convert
all arguments and environment vars and that makes
debugging msys2 software with strace very tricky.
We really must not run outside of the buffer. And the buffer needs to be
NUL-terminated, too...

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Instead of doing a poor man's realloc(), we can call the real thing ;-)

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When the result of conversion is identical to the original argument, we
should make sure that the temporary buffer was released.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
If we were to handle only single paths, the buffer really would only
need to fit a single one, but arg_heuristic is also used to convert e.g.
INFO_PATH and MAN_PATH (which can contain multiple absolute POSIX-style
paths that need to be converted to Windows-style paths).

This is only really relevant if the POSIX root directory's path is
already pretty long. Such a beast has been spotted in the wild, in the
Git for Windows project:

	git-for-windows/git#303

Of course, this patch is only a work-around that helps in many, but not
all cases. Obviously this patch will wait patiently until a real fix
comes around the corner, and then readily retire.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@Karlson2k
Copy link
Author

@Alexpux Need any correction?

@Alexpux Alexpux force-pushed the msys2-master branch 2 times, most recently from e0493ab to 63be0b3 Compare January 23, 2017 10:58
@Alexpux Alexpux force-pushed the msys2-master branch 2 times, most recently from e188477 to c739057 Compare June 25, 2018 18:21
@Alexpux Alexpux force-pushed the msys2-master branch 2 times, most recently from 44f4482 to ff12737 Compare July 6, 2018 18:33
@mirh
Copy link

mirh commented Jul 28, 2018

Mhh.. up?
(EDIT: p.s. non-admin symlinks can also be fixed)

@Alexpux
Copy link
Owner

Alexpux commented Jul 30, 2018

This repository is only for my own use t o sync with cygwin. Create pull request with patch to https://github.com/Alexpux/MSYS2-packages for msys2-runtime package

@Alexpux Alexpux force-pushed the msys2-master branch 3 times, most recently from 9b65e3b to 7fdb399 Compare April 15, 2019 06:41
@Alexpux Alexpux force-pushed the msys2-master branch 4 times, most recently from 28b70c4 to 24a8f59 Compare June 20, 2019 19:57
@Alexpux Alexpux force-pushed the msys2-master branch 2 times, most recently from bb02ac2 to 67bf1d3 Compare July 11, 2019 20:21
@Alexpux Alexpux force-pushed the msys2-master branch 2 times, most recently from 6a70885 to 20139df Compare July 25, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants