Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] compile error on i586: expected (), found FPUControlWord #218

Open
jvdd opened this issue Feb 6, 2025 · 2 comments · Fixed by #219
Open

[BUG] compile error on i586: expected (), found FPUControlWord #218

jvdd opened this issue Feb 6, 2025 · 2 comments · Fixed by #219
Assignees
Labels
bug Something isn't working targets Affects non-tier 1 targets.
Milestone

Comments

@jvdd
Copy link

jvdd commented Feb 6, 2025

Description

When compiling this crate in GitHub actions on a i586-unknown-linux-gnu target, the following error occurs

   Compiling lexical-parse-float v1.0.5
error[E0308]: mismatched types
  --> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/lexical-parse-float-1.0.5/src/number.rs:77:23
   |
77 |         let _cw: () = set_precision::<F>();
   |                  --   ^^^^^^^^^^^^^^^^^^^^ expected `()`, found `FPUControlWord`
   |                  |
   |                  expected due to this

For more information about this error, try `rustc --explain E0308`.
error: could not compile `lexical-parse-float` (lib) due to 1 previous error

let _cw: () = set_precision::<F>();

Prerequisites

  • Rust version: nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.86.0-nightly (bef3c3b01 2025-02-04)
  • lexical version: lexical-parse-float v1.0.5 (lexical-util is v1.0.6)
  • lexical compilation features used: (default?)

Additional Context

The link to the GitHub CI that fails:

https://github.com/jvdd/argminmax/actions/runs/13158734781/job/36726072805

@jvdd jvdd added the bug Something isn't working label Feb 6, 2025
@Alexhuszagh
Copy link
Owner

Alexhuszagh commented Feb 6, 2025

I was able to replicate this using cross build --target i586-unknown-linux-gnu, so this is confirmed and likely should be added to CI as well. I'll have to check if this affects correctness so this must be tested in CI as well. This does not affect the i686-unknown-linux-gnu target, so this is fully confirmed.

Thank you for discovering this.

@Alexhuszagh Alexhuszagh added this to the 1.0.6 milestone Feb 6, 2025
@Alexhuszagh Alexhuszagh added the targets Affects non-tier 1 targets. label Feb 6, 2025
Alexhuszagh added a commit that referenced this issue Feb 6, 2025
Alexhuszagh added a commit that referenced this issue Feb 6, 2025
Alexhuszagh added a commit that referenced this issue Feb 6, 2025
Alexhuszagh added a commit that referenced this issue Feb 6, 2025
@Alexhuszagh
Copy link
Owner

Reopening this until a release is published.

@Alexhuszagh Alexhuszagh reopened this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working targets Affects non-tier 1 targets.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants