Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unit tests failures #169

Closed
alexanderkjall opened this issue Oct 15, 2024 · 8 comments · Fixed by #185
Closed

[BUG] Unit tests failures #169

alexanderkjall opened this issue Oct 15, 2024 · 8 comments · Fixed by #185
Assignees
Labels
bug Something isn't working correctness can lead to incorrectt parsing results high priority High priority regression Performance regressions.
Milestone

Comments

@alexanderkjall
Copy link

Description

cargo test --no-default-features --features radix fails two unit tests: i128_proptest_radix and u128_proptest_radix` on my amd64 machine.

Prerequisites

Here are a few things you should provide to help me understand the issue:

  • Rust version: rustc 1.81.0 (eeb90cda1 2024-09-04) (Arch Linux rust 1:1.81.0-1)
  • lexical version: 1.0.2
  • lexical compilation features used: --no-default-features --features radix

Test case

See above, it's the existing unit tests.

Additional Context

cargo test --no-default-features --features power-of-two also have some failing tests: binary_test and u128toa_proptest

@alexanderkjall alexanderkjall added the bug Something isn't working label Oct 15, 2024
@alexanderkjall
Copy link
Author

forgot to add: this is for the lexical-write-integer crate

@Alexhuszagh Alexhuszagh added the high priority High priority label Oct 15, 2024
@Alexhuszagh Alexhuszagh added this to the 1.0.3 milestone Oct 15, 2024
@Alexhuszagh
Copy link
Owner

Alexhuszagh commented Oct 15, 2024

Attaching the output of the failures:

power-of-two.txt
radix.txt

This seems to be a regression which wasn't covered in our CI because we only test the intersection if compact,radix and not just radix. I'll make sure this is covered in CI as well.

@Alexhuszagh Alexhuszagh added correctness can lead to incorrectt parsing results regression Performance regressions. labels Oct 15, 2024
@Alexhuszagh
Copy link
Owner

Alexhuszagh commented Oct 15, 2024

I've diagnosed the cause of the issue, will have a patch incoming shortly and an immediately release once patched. This never should have made it to production, not having this specific case covered in CI is a major oversight on my part and I'll make sure this case is always covered in CI going forward.

@alexanderkjall
Copy link
Author

Thanks for being so responsive :)

@Alexhuszagh
Copy link
Owner

Alexhuszagh commented Oct 31, 2024

Sorry I haven't forgotten about this and am working on it. Other open source work and my day job have gotten in the way. This is still my highest priority for this crate at the moment.

@Alexhuszagh
Copy link
Owner

Sorry for the massive delay on this, I've implemented a large number of patches and optimizations and completed this. I will be drafting up a release shortly.

@Alexhuszagh
Copy link
Owner

Published as of version 1.0.3.

@alexanderkjall
Copy link
Author

thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctness can lead to incorrectt parsing results high priority High priority regression Performance regressions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants