Add an option to use battery design capacity #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntage informations
Alexays
requested changes
Jan 18, 2021
src/modules/battery.cpp
Outdated
| } | ||
| if (!adapter_.empty() && status == "Discharging") { | ||
| bool online; | ||
| std::ifstream(adapter_ / "online") >> online; | ||
| if (online) { | ||
| if (online) { |
|
Hi, thanks for the change. |
|
Sorry this change wasn't intended. |
|
LGTM, thx, could you update github wiki? |
|
Done, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little PR implements a new option
design-capacityto the battery module with default valuefalse. If set totrue, Waybar will use the design capacity of the battery instead of the actual full capacity which may be lower due to deterioration of the battery. With this option, ti should report the same battery percentage than i3status' default behavior.I personally like to see it this way because I know how worn off my battery is.
I will edit the wiki as soon as you merge this PR.