UI module #3704
Open
UI module #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Alexays , during routine on migration waybar from gtk3 to gtk4 and doing merging commits are left I found commit 884b909e whuch brings an opportunity to have a user defined menu. It looks a little bit strange to extend base AModule for that purpose. In the gtk4 branch, I realized another concept - a separate UI module that brings an opportunity to construct UI elements based on provided gtk builder xml specification. So, in the GTK4 branch, I removed AModule extension and replaced it with the UI module. In the current master branch, I decided not to drop current implementation but just provide new functionality with the UI module.