Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3442 #3443

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix #3442 #3443

merged 1 commit into from
Jul 17, 2024

Conversation

yangyingchao
Copy link
Contributor

I'm not sure if this is a proper fix; please have it reviewed before merging.

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked here locally to fix the issue, thanks!

@RobertMueller2
Copy link
Contributor

I've tested it too and it fixes all the problems I've seen with the module. I think this might also address #3430 and #3310.

I can't help but wonder if looking at this

nb_hosts_ += 1;

might avoid the situation altogether. nb_hosts_ is a static variable that will be used for Host's id which ensures multi monitor trays will have unique ids but when running more than one instance of waybar of course it isn't globally unique. And other programs having a tray might also just start from 0. I don't have a suggestion how to deal with it, and I don't mean to stop the PR. I've not seen any problems with it, either. Just wanted to leave this here in case somebody picks up more work on the module in the future.

khaneliman added a commit to khaneliman/khanelinix that referenced this pull request Jul 17, 2024
@Alexays Alexays merged commit 496dd05 into Alexays:master Jul 17, 2024
8 of 9 checks passed
@Alexays
Copy link
Owner

Alexays commented Jul 17, 2024

LGTM, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants