Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/hyprland/backend: handle empty socket response #3389

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Jun 28, 2024

Issues:

This PR:

  • We will check for an empty response from getSocketReply before trying to parse JSON. Before the empty response check we get the JSON parse error from the JSON module. After the change, we wont try and parse the message that will cause the crash.
  • Also includes some clangd cleanup.
  • Added test to verify we dont crash when we receive an empty socket response.

@Alexays
Copy link
Owner

Alexays commented Jun 28, 2024

Thanks!

@khaneliman khaneliman deleted the cleanup branch June 28, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crashes due to many uncaught exceptions in hyprland module Waybar crash after hyprctl dpms off/on
2 participants