-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Clock. Tooltip calendar text overflows(#2240) #3255
Conversation
Hi @Alexays , ping ) |
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com>
Hi @Alexays , finally this MR is ready to merge. According discussion here Label set_markup tooltips width for the Widget class is limited. |
Hi @Alexays , ping |
Hi @Alexays , ping once again ) |
Hi @Alexays , any feedback ? |
Hi @Alexays , ping again |
Amazing, thanks for this PR! |
@Alexays any feedback? |
@Alexays ? |
It looks like Alexays is unavailable right now (travelling, on vacation, ...). I'm sure he will see your pings once he is available again. I don't think pinging him every few hours helps. |
LGTM, and yes i was on vacation :) |
Thanks @LukashonakV for providing the fix, can't wait to try it out. |
Hi @Alexays, @FilippoBonazziSUSE this MR solves #2240
Actually here it's GtkLabel wrong behavior with tooltips. Even @BrianCArnold has found workaround it's better to have code fixed.
Temporary for now I replaced clock label with Gtk::TextView. In order to have the same styling as it was for tooltips in the system, users should use next css styling
For now I'm trying to write test case in pure C in order to provide it gtk maintainers to fix gtk
So fixed variant looks good