Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clock. Tooltip calendar text overflows(#2240) #3255

Merged
merged 1 commit into from
May 28, 2024

Conversation

LukashonakV
Copy link
Contributor

@LukashonakV LukashonakV commented May 10, 2024

Hi @Alexays, @FilippoBonazziSUSE this MR solves #2240
Actually here it's GtkLabel wrong behavior with tooltips. Even @BrianCArnold has found workaround it's better to have code fixed.
Temporary for now I replaced clock label with Gtk::TextView. In order to have the same styling as it was for tooltips in the system, users should use next css styling

textview#clock.tooltip, textview#clock.tooltip text {
   background-color: inherit;
   padding: inherit;
}

For now I'm trying to write test case in pure C in order to provide it gtk maintainers to fix gtk

So fixed variant looks good
ps_2024-05-11-01_06_12

@LukashonakV LukashonakV changed the title Clock. Tooltip textview Clock. Tooltip calendar text overflows(#2240) May 10, 2024
@LukashonakV
Copy link
Contributor Author

Hi @Alexays , ping )

Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com>
@LukashonakV
Copy link
Contributor Author

Hi @Alexays , finally this MR is ready to merge. According discussion here Label set_markup tooltips width for the Widget class is limited.
So for now I found the better solution using one more Gtk::Label as a tooltip for the base Clock label. And then to set_markup for this tooltip label. Such approach allows solve #2240 without any additional CSS style customization from the user

@LukashonakV
Copy link
Contributor Author

Hi @Alexays , ping

@LukashonakV
Copy link
Contributor Author

Hi @Alexays , ping once again )

@LukashonakV
Copy link
Contributor Author

Hi @Alexays , any feedback ?

@LukashonakV
Copy link
Contributor Author

Hi @Alexays , ping again

@alkar
Copy link

alkar commented May 23, 2024

Amazing, thanks for this PR!

@LukashonakV
Copy link
Contributor Author

@Alexays any feedback?

@LukashonakV LukashonakV changed the title Clock. Tooltip calendar text overflows(#2240) Fix Clock. Tooltip calendar text overflows(#2240) May 24, 2024
@LukashonakV
Copy link
Contributor Author

@Alexays ?

@FilippoBonazziSUSE
Copy link

It looks like Alexays is unavailable right now (travelling, on vacation, ...). I'm sure he will see your pings once he is available again. I don't think pinging him every few hours helps.

@Alexays
Copy link
Owner

Alexays commented May 28, 2024

LGTM, and yes i was on vacation :)

@Alexays Alexays merged commit d4413f5 into Alexays:master May 28, 2024
8 checks passed
@FilippoBonazziSUSE
Copy link

Thanks @LukashonakV for providing the fix, can't wait to try it out.

@LukashonakV LukashonakV deleted the ISSUE#2240 branch May 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants