fix(battery): Fix {health} format replacement
#3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
At least I hope I copy-pased it correctly
This is what happens when you copy-paste from GitHub actions
It's now *inconsistent* in the file, but clang-tidy should be happy, sooo...
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I forgot to register the
{health}replacement for the "default" (i.e. non-tooltip) replacements.Also, some batteries report their
{health}related data asenergy_fullandenergy_full_designinstead ofcharge_fullandcharge_full_design. This PRwillalso implements support for that.For more information see the conversation below #3130
Marking as draft sinceI haven't tested this yet (quick commit from the web editor)there might actually be another / more issue(s) with{cycles}and{health}informat-altIssues reported by @nebulosa2007 under the original PR for
{cycles}and{health}(#3130)