Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update clock tooltip without placeholders #3155

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

drendog
Copy link
Contributor

@drendog drendog commented Apr 21, 2024

Currently the tooltip is updated only if a placeholder (like calendar, tz_list, ordinal_date) is present, because the formatting string tlpFmt_ is taken as reference, while if no placeholder is present, the tooltip will get the text formatted processed at the first time, then it will never be updated. To ensure that the tooltip will update in this scenario, we can set the tooltip string back as the formatting string, before the formatting occurs.

Here is the config to test it:

    "clock": {
        "tooltip-format": "{:%H:%M %Y-%m-%d}",
        "format": "{:%H:%M %Y-%m-%d}",
    }

@Alexays Alexays merged commit 5ce5ceb into Alexays:master Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants