fix: update clock tooltip without placeholders #3155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tooltip is updated only if a placeholder (like
calendar
,tz_list
,ordinal_date
) is present, because the formatting stringtlpFmt_
is taken as reference, while if no placeholder is present, the tooltip will get the text formatted processed at the first time, then it will never be updated. To ensure that the tooltip will update in this scenario, we can set the tooltip string back as the formatting string, before the formatting occurs.Here is the config to test it: