Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hyprland/workspaces] New options to change on click behaviour and active workspace status #2987

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

tomben13
Copy link

@tomben13 tomben13 commented Mar 4, 2024

Option move-to-monitor:
Use hyprctl dispatch focusworkspaceoncurrentmonitor when clicking on workspace button

Option active-per-monitor:
Each bar on each monitor has its own active workspace. So instead of all the bars showing the same workspace which is currently active, each show the currently active workspace of the bar's monitor.

This may require additional testing. Also I hope this doesn't break backwards compatibility, especially with special workspaces. I didn't test, but it should be fine as I didn't change anything special workspace related.

@tomben13
Copy link
Author

tomben13 commented Mar 5, 2024

I will remove option active-per-monitor from this PR as it is being handled by #2968 already. And #2968 is a way better solution.

@tomben13
Copy link
Author

@Alexays I think this can be merged as is. We could implement a similar option for special workspaces but I tested and focusworkspaceoncurrentmonitor doesn't work correctly for special workspaces currently in Hyprland.

Also, this PR doesn't break backwards compatibilty, it's an opt-in option.

@Alexays Alexays merged commit e30ddda into Alexays:master Mar 22, 2024
8 of 9 checks passed
@Alexays
Copy link
Owner

Alexays commented Mar 22, 2024

Thanks, can you also update the Github wiki?

@tomben13
Copy link
Author

Thanks, can you also update the Github wiki?

Done

@simonwiles
Copy link

simonwiles commented Apr 23, 2024

I will remove option active-per-monitor from this PR as it is being handled by #2968 already. And #2968 is a way better solution.

I don't think #2968 covers the same use-case, fwiw. I was hoping to be able to target only the currently visible workspace on each monitor; .hosting-monitor from #2968 targets every workspace on the given monitor, and .active is only applied on the focussed monitor (so I can't use, e.g., .hosting-monitor.active).

Edit: sorry, I went too soon there; .hosting-monitor.visible is what I was after. Sorry (and thanks!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants