-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding css reloader #2852
Adding css reloader #2852
Conversation
The code changes the global GTK app state from a thread, which is not safe. Have you considered using Gio::FileMonitor or the underlying g_file_monitor instead? That would address both points. Also, please consider adding a flag to disable the file watcher or even make it opt-in. |
Updated with the changes suggested above. |
LGTM, thx to both of you! |
I added the man page entry and edited the wiki. |
Can you check the CI, freebsd seems to fail @dpayne |
* Fixing missing includes * Fixing formatting
I believe I fixed the compilation error in freebsd, it was an issue with a missing import that only errors out on clang. I do not know why it hung after. It did seem to compile, this is from the workflow logs
|
LGTM, thx! |
This adds a css file watcher that reloads the style if the css files change.
A common use case is changing the colors of waybar using pywal. I wanted to make the change seamless, a full reset causes hyprland to briefly change window sizes since the gtk window is destroyed and recreated. Reloading only the style avoids that issue.