Require gtk-layer-shell #2836
Merged
Require gtk-layer-shell #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
BREAKING CHANGE: gtk-layer-shell is now required and unconditionally used. The corresponding config option is removed. As a part of preparation for future versions of GTK, remove an ability to use wlr-layer-shell directly. The APIs it required were dropped in GTK4, and with the menus/tooltips positioning issue being practically unsolvable it doesn't make sense to keep maintaining the code.
`gtk_layer_set_keyboard_interactivity()` is deprecated and was removed in gtk4-layer-shell. Note that this bumps version requirement to 0.6.0
alebastr
force-pushed
the
require-gtk-layer-shell
branch
from
76cbf3a
to
3cb5879
Compare
`string_view` leads to UAF when reading custom mode definitions from the configuration.
With only one implementation left, the abstraction is no longer necessary.
|
Merging it to be apart of the upcoming release of the next month. |
brettalcox
added a commit
to brettalcox/gentoo
that referenced
this pull request
Feb 24, 2024
requiring gtk-layer-shell in 9999 as it is now unconditionally required as a dependency. See Alexays/Waybar#2836 Signed-off-by: brettalcox <brettalcox@gmail.com>
brettalcox
added a commit
to brettalcox/gentoo
that referenced
this pull request
Feb 24, 2024
requiring gtk-layer-shell in 9999 as it is now unconditionally required as a dependency. See Alexays/Waybar#2836 Closes: https://bugs.gentoo.org/925017 Signed-off-by: brettalcox <brettalcox@gmail.com>
brettalcox
added a commit
to brettalcox/gentoo
that referenced
this pull request
Feb 24, 2024
requiring gtk-layer-shell in 9999 as it is now unconditionally required as a dependency. See Alexays/Waybar#2836 Closes: https://bugs.gentoo.org/925017 Signed-off-by: brettalcox <brettalcox@gmail.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Feb 26, 2024
requiring gtk-layer-shell in 9999 as it is now unconditionally required as a dependency. See Alexays/Waybar#2836 Closes: https://bugs.gentoo.org/925017 Closes: #35514 Signed-off-by: brettalcox <brettalcox@gmail.com> Acked-by: Julien Roy <julien@jroy.ca> Signed-off-by: Yixun Lan <dlan@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: gtk-layer-shell is now required and unconditionally used. The corresponding config option is removed.
As a part of preparation for future versions of GTK, remove an ability to use wlr-layer-shell directly. The APIs it required were dropped in GTK4, and with the menus/tooltips positioning issue being practically unsolvable it doesn't make sense to keep maintaining the code.
See: #2815