Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module systemd-failed-units to monitor failed systemd units #2820

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Jan 9, 2024

This module monitors the number of failed systemd units and can warn user if there is something going wrong. It's especially useful for periodic services.

Currently only the count is monitored and displayed, and there's no tooltip. It's nontrivial to get the actual failed unit names and it seems to require enumerating all units and then filter, which would be too CPU intensive to be done frequently.

Related but not equivalent to #1187.

@Alexays
Copy link
Owner

Alexays commented Jan 12, 2024

LGTM!
Can you also add a new entry in the github wiki?

@Alexays Alexays merged commit f744d90 into Alexays:master Jan 12, 2024
@oxalica oxalica deleted the feat/systemd-failed-units branch January 12, 2024 11:54
@oxalica
Copy link
Contributor Author

oxalica commented Jan 12, 2024

Can you also add a new entry in the github wiki?

Added https://github.com/Alexays/Waybar/wiki/Module:-Systemd-failed-units

@HilkopterBob
Copy link

HilkopterBob commented Jan 24, 2024

ive tried for days to use it. Please edit the wiki so its visible its a draft and not published and maybe remember that for future features/wiki articles

@oxalica
Copy link
Contributor Author

oxalica commented Jan 24, 2024

@HilkopterBob

Please edit the wiki so its visible its a draft and not published

I tried in a private browser session without signing in GitHub and the page is public visible. There's no "draft" or anything relevant state, button or toggles in the edit page. The link above is also working publicly. Maybe you need to refresh your browser cache and try again? Or could you elaborate why you think it's "draft state and not published" and how to fix it?

@HilkopterBob
Copy link

HilkopterBob commented Jan 24, 2024

Sorry, i meant that the feature isnt published yet and i think that should be visible in the wiki article.
Sorry for the miscommunication.

@oxalica
Copy link
Contributor Author

oxalica commented Jan 24, 2024

Sorry, i meant that the feature isnt published yet and i think that should be visible in the wiki article.

Ah, that makes sense. I added a warning to the wiki. Thanks.

@andyrtr
Copy link

andyrtr commented Mar 28, 2024

Is there a way to style the colour of format-ok/format in style.css to make the small but helpful notification more visible or would this require additional changes to the source?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants