Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:the workspace data is null in a small probability #2764

Closed
wants to merge 1 commit into from
Closed

fix:the workspace data is null in a small probability #2764

wants to merge 1 commit into from

Conversation

DreamMaoMao
Copy link
Contributor

Hey, i found a small probability bug.

the workspaceToCreate json object is ready in here:
image

but sometime,when the workspaceToCreate json data which get from m_workspacesToCreate in here will be null.
image

@DreamMaoMao
Copy link
Contributor Author

waybar crash, coredump:

image

@DreamMaoMao
Copy link
Contributor Author

2023-12-24.09-36-24.mp4

With the addition of read-write locks, it can now create 30 workspaces simultaneously and has run over 100 tests without any problems

@Syndelis
What do you think about that?

@DreamMaoMao
Copy link
Contributor Author

Relate to issue:#2769

@DreamMaoMao
Copy link
Contributor Author

how aboout this? @Alexays

@DreamMaoMao
fix:the workspace data is null in a small probability
e64d66a 
update

fix clang-format warn

no manual unlock
@DreamMaoMao DreamMaoMao closed this by deleting the head repository Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DreamMaoMao