Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clang-tidy GitHub action #2755

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Added clang-tidy GitHub action #2755

merged 1 commit into from
Dec 20, 2023

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented Dec 19, 2023

No description provided.

@zjeffer
Copy link
Contributor Author

zjeffer commented Dec 19, 2023

@Alexays can you update the debian Docker image now that #2742 is merged? Thanks

@Alexays
Copy link
Owner

Alexays commented Dec 19, 2023

@Alexays can you update the debian Docker image now that #2742 is merged? Thanks

Done! :)

@zjeffer zjeffer force-pushed the master branch 3 times, most recently from 63fd211 to 521e142 Compare December 19, 2023 18:14
@zjeffer
Copy link
Contributor Author

zjeffer commented Dec 19, 2023

Thanks! I'm still fixing some small issues with the action, I'll ping you once it's ready to merge.

@zjeffer zjeffer force-pushed the master branch 6 times, most recently from c1a7710 to 2224ae3 Compare December 20, 2023 11:43
@zjeffer
Copy link
Contributor Author

zjeffer commented Dec 20, 2023

@Alexays I included a change to a cpp file to give an example of a clang-tidy warning:

image

Let me know if this is ok, and I can then revert that change.

Right now the action is still using my own fork of the cpp-linter-action, we should hold off on merging until this PR is merged and a new cpp-linter-action release is made.

@Alexays
Copy link
Owner

Alexays commented Dec 20, 2023

LGTM!
Nice :)

Created clang-tidy.yml
Renamed lint.yml to clang-format.yml
@Alexays Alexays merged commit 2674982 into Alexays:master Dec 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants