cpu_usage/linux: count iowait toward idle time #2681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
iowait
time present in/proc/stat
is a sub-category of idle, and therefore shouldn't count toward CPU usage. However, Waybar doesn't account for it when calculating the idle time, giving wrong results in some cases.For example, when running the following command on an idle system, to create a completely I/O bound task pinned to the first CPU:
Waybar displays the first CPU at 100% usage, which is incorrect, since the CPU is idle most of the time waiting for I/O, while other tools such as
htop
display the same CPU fairly close to 0%.