tray: load_icon use request_size directly #2626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I delete tmp_size part, when call
load_icon
function, use request_sizeicon_size * image.get_scale_factor()
like wlr/taskbarget_icon_sizes
doesn't handle scaling, if icon isn't scalable, tmp_size will be smaller sizeWaybar/src/modules/wlr/taskbar.cpp
Lines 181 to 184 in 1149e51
for example: nm-applet