Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tray: load_icon use request_size directly #2626

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

akliuxingyuan
Copy link
Contributor

@akliuxingyuan akliuxingyuan commented Nov 1, 2023

I delete tmp_size part, when call load_icon function, use request_size icon_size * image.get_scale_factor() like wlr/taskbar
get_icon_sizes doesn't handle scaling, if icon isn't scalable, tmp_size will be smaller size

auto scaled_icon_size = size * image.get_scale_factor();
try {
pixbuf = icon_theme->load_icon(ret_icon_name, scaled_icon_size, Gtk::ICON_LOOKUP_FORCE_SIZE);

for example: nm-applet
2023-11-01_22-38
2023-11-01_22-37

@Alexays Alexays merged commit 22dc879 into Alexays:master Nov 1, 2023
7 of 8 checks passed
@archseer
Copy link

I think this ruined scaling on my bar for certain icons: They used to be the same size, but now the volume icons, the first workspace icon and the CPU icon are slightly smaller than the rest. I'm using Font Awesome for all of them.
icons

@archseer
Copy link

Hmm maybe not since the icons are a part of the font, not a separate image. I need to do a bisect from the last release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants