Fixed variable synchronization exception caused by the "hyprland/workspace" module #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…space" module receiving create or delete IPC requests too quickly
|
Hi, thanks for the fix! |
|
I feel like it would be cleaner with some kind of mutex locking solution, no? Then we make sure the vector is not accessed when we update(). I don't really have time to look into that, though. |
If the vector is locked during the update, then if the event is triggered at this time, won’t the creation and removal requests be lost? |
|
To ensure that requests are not lost, the vector used to receive buffering should not be locked from writing at any time. It's like a keyboard's input buffer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey i want to fix:#2607
I've tested this commit several times.
2023-10-27.14-10-40.mp4