hyprland/workspaces: use name as fallback icon
#2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wlr and Sway modules use the workspace `name` as the default icon if no icon is provided. This adds the same behavior for the `hyprland/workspace` module. Closes #2533
|
Wlr impl: Waybar/src/modules/wlr/workspace_manager.cpp Line 519 in 6997b34 Sway impl: Waybar/src/modules/sway/workspaces.cpp Line 326 in 6997b34 |
zjeffer
approved these changes
Sep 23, 2023
woojiq
changed the title
name as default iconname as fallback icon
woojiq
changed the title
name as fallback iconname as fallback icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wlr and Sway modules use the workspace
nameas the default icon if no icon is provided. This adds the same behavior for thehyprland/workspacemodule.Closes #2533
Before this fix, it defaulted to the last defined icon, which is silly (see above issue).