-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON parsing with hexadecimal characters #2496
Conversation
* replace \x with \u00 to follow JSON spec * fixes Alexays#2475 and Alexays#2495 * added unit tests for json parsing
@Nyayurn can you test if you still have your bug with this new parser? |
It's fine |
Can you show the console output, I'd like to see if there are any errors from the clock component. |
@Nyayurn with your config, I get the same error on latest master. I think the clock icon needs to be outside of the {} brackets, like this: It works for me on both latest master and this PR: |
Thanks, It's work now |
@Alexays This is ready to be reviewed. |
LGTM, thx for this fix! |
Fixes #2495 and #2475
The JSON spec doesn't allow characters like
\xab
. Instead, it should be converted to unicode:\u00ab
.It's my first time writing catch2 tests, let me know if I did something wrong.