Add format-no-controller to bluetooth module and fix it still being visible if the format string is empty #2413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2163
This PR contains the following changes:
format-no-controller
andtooltip-format-no-controller
format strings that will be used if no bluetooth controller could be found.The reason for why the bluetooth module was still being displayed is the return statement in the constructor of the bluetooth module:
Waybar/src/modules/bluetooth.cpp
Lines 95 to 106 in aecd807
This return statement caused
dp.emit()
not to be called and somehow this removed the ability for the module to hide.I also think that it makes sense to have an additional format string for the case when the system does not have a bluetooth controller. If the user still wants to hide the bluetooth module he just needs to set
format-no-controller
to an empty string.