Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add river/layout #1991

Merged
merged 4 commits into from
Mar 1, 2023
Merged

add river/layout #1991

merged 4 commits into from
Mar 1, 2023

Conversation

alex-courtis
Copy link
Contributor

Similar functionality to river/window but shows layout.

Updated river output status protocol 2->4

Tested OK:

  • hotplug monitor
  • river output status version 2 - module does not load
  • css classes
  • all configuration options

}

label_.hide();
ALabel::update();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not initially hide the label. I did notice the same behaviour from window... any ideas?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because the label isn't empty, and so ALabel::update re-show it 🤔

@alex-courtis
Copy link
Contributor Author

It looks like there was an infrastructural issue with the builds. Can I re-run the builds?

Should I push a dummy commit to force a re-run?

@alex-courtis
Copy link
Contributor Author

alex-courtis commented Feb 11, 2023

Merged master and updated to obey cpp_std=c++20

Should we update meson.build default options from c++17 to c++20?

@alex-courtis
Copy link
Contributor Author

I'll add to the wiki after merge.

@Alexays Alexays merged commit c9c8b09 into Alexays:master Mar 1, 2023
@pinpox
Copy link

pinpox commented Mar 25, 2023

@alex-courtis How do I make this work with river-luatile? Where do I have to specify the layout name?

@alex-courtis
Copy link
Contributor Author

@alex-courtis How do I make this work with river-luatile? Where do I have to specify the layout name?

It's up to river-luatile to specify the layout name each time it pushes/commits.

The name seems to be specified here:
https://github.com/MaxVerevkin/river-luatile/blob/0ae8e1ca68417878674469def3c861a148fac867/src/main.rs#L55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants