-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add river/layout #1991
add river/layout #1991
Conversation
} | ||
|
||
label_.hide(); | ||
ALabel::update(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not initially hide the label. I did notice the same behaviour from window... any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe because the label isn't empty, and so ALabel::update re-show it 🤔
It looks like there was an infrastructural issue with the builds. Can I re-run the builds? Should I push a dummy commit to force a re-run? |
Merged master and updated to obey Should we update |
I'll add to the wiki after merge. |
@alex-courtis How do I make this work with |
It's up to The name seems to be specified here: |
Similar functionality to river/window but shows layout.
Updated river output status protocol 2->4
Tested OK: