wlr-taskbar: allow sorting by app_id #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldelossa
force-pushed
the
wlr-taskbar-sort-app-id
branch
from
aa9b128
to
b201457
Compare
Alexays
reviewed
Jan 24, 2023
include/modules/wlr/taskbar.hpp
Outdated
| @@ -40,6 +40,8 @@ class Task { | |||
| FULLSCREEN = (1 << 3), | |||
| INVALID = (1 << 4) | |||
| }; | |||
| // made public so TaskBar can reorder based on configuration. | |||
| Gtk::Button button_; | |||
There was a problem hiding this comment.
button_ really need to be public?
If yes please remove the _ :)
There was a problem hiding this comment.
Button on this Task class needs to be public or else TaskBar class cannot access it to sort and move the button.
There is an alternative way which I mention in the PR comments, but I thought this was cleaner.
Ill remove the underscore as well, missed that.
ldelossa
force-pushed
the
wlr-taskbar-sort-app-id
branch
2 times, most recently
from
498e7f1
to
9bcb08c
Compare
|
@Alexays fixed linting errors. |
|
@Alexays do you think this is OK to merge ? |
ldelossa
force-pushed
the
wlr-taskbar-sort-app-id
branch
from
9bcb08c
to
7cd21ec
Compare
|
Sorry again for the delay, your branch seems broken, can you rebase it on master? |
some users (maybe only myself) may want to sort the task bar by app_id which then places occurrences of the same task next to each other. Signed-off-by: Louis DeLosSantos <louis.delos@gmail.com>
ldelossa
force-pushed
the
wlr-taskbar-sort-app-id
branch
from
7cd21ec
to
79eb2f5
Compare
|
@Alexays no worries at all, rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some users (maybe only myself) may want to sort the task bar by app_id which then places occurrences of the same task next to each other.
there is an alternative method to do this, making TaskBar's
tasks_vector public, and having each Task find itself intbar_->tasks_and setting their button in the right place, but it "feels" better to have TaskBar decide to place where its Task(s) should be within itself.Signed-off-by: Louis DeLosSantos louis.delos@gmail.com