-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPU usage for every core #1250
Conversation
Very nice! |
Done. |
Also, I have found eerie comment: Waybar/src/modules/cpu/common.cpp Line 12 in 8da940f
@Alexays, do you know what it was about? |
It was for an older version of fmt I think. |
Thanks! |
Rollbacked as CI failed :/ |
It didn't build on Fedora. I've checked tests of fmt lib and including I can try to create PR that will add fmt as dependency. Will you merge such PR, @Alexays? |
It didn't built as Fedora (and a few more distributions according to repology) ships fmt 7.x in the stable releases. I'm pretty sure that if CI had reached Debian it would fail in the same way. As a Fedora maintainer of waybar package, I'd prefer if we can keep compatibility with older fmt. There are policies that discourage us from having third party libraries bundled in the package source, so I'll have to deal with reverting the change downstream in Fedora. As far as I can see, 7.x has required classes in the |
This MR adds usage and icon for every CPU core. Use in format like
{usage0}
,{usage1}
and etc. You can build nice graph for CPU with it:P.S.
Sorry, I haven't write in C++ for years, so code can very bad.
UPD:
Found that there is relevant feature request: #746