Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to use a .jsonc extension for the config filename #1112

Merged
merged 2 commits into from
May 21, 2021

Conversation

yonatan8070
Copy link
Contributor

@yonatan8070 yonatan8070 commented May 21, 2021

This is to allow text editors such as Visual Studio Code to recognize that the file is a JSON file and add syntax highlighting accordingly

@Alexays
Copy link
Owner

Alexays commented May 21, 2021

The proper format is jsonc for json with comment.

@yonatan8070
Copy link
Contributor Author

Fixed it

@Alexays Alexays merged commit 826a549 into Alexays:master May 21, 2021
@Alexays
Copy link
Owner

Alexays commented May 21, 2021

Thanks!

@WhyNotHugo
Copy link
Contributor

WhyNotHugo commented May 22, 2021

PR title and commit message still say json. Should read jsonc. Just a mention so it's kept in mind when it comes to release notes.

@WhyNotHugo
Copy link
Contributor

Oh, thanks a bunch for this change, it's one of those little things that always bothered me!

@yonatan8070 yonatan8070 changed the title Add options to use a .json extension for the config filename Add options to use a .jsonc extension for the config filename May 22, 2021
@yonatan8070
Copy link
Contributor Author

PR title and commit message still say json. Should read jsonc. Just a mention so it's kept in mind when it comes to release notes.

Thanks for the heads up, corrected.

@sethidden
Copy link

@yonatan8070 I noticed that man waybar shows this:

DESCRIPTION
       The configuration uses the JSON file format and is named config.

       Valid locations for this file are:

       •   $XDG_CONFIG_HOME/waybar/config
       •   ~/.config/waybar/config
       •   ~/waybar/config
       •   /etc/xdg/waybar/config
       •   /etc/xdg/waybar/config

Would it be appropriate to mention that all of those are also valid with a .jsonc extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants