Add option to rewrite sway/window title #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed test seems to be caused by the runner, not by the changed code:
|
|
@Alexays is anything missing? |
|
LGTM, can you update the man in order to add the change? |
Alexays
approved these changes
Apr 15, 2021
|
Very cool, using this locally and it's working like a charm! +1 for this feature. |
Synthetica9
approved these changes
Apr 20, 2021
Synthetica9
suggested changes
Apr 21, 2021
Rewrites window title according to config option "rewrite".
"rewrite" is an object where keys are regular expressions and values are
rewrite rules if the expression matches. Rules may contain references to
captures of the expression. Regex and replacement follow ECMA-script
rules. If no regex matches, the title is left unchanged.
example:
"sway/window": {
"rewrite": {
"(.*) - Mozilla Firefox": " $1",
"(.*) - zsh": " $1",
}
}
std::regex and std::regex_replace may throw an std::regex_error if the expression or replacement contain errors. Log this error and carry on with the next rule, so that the title is shown even if the config contains errors.
Add section on rewrite rules and extend example
vrld
force-pushed
the
feature-rewrite-window-title
branch
from
6a1a0f5
to
7cdf178
Compare
|
@Synthetica9 Good catch. Added try/catch around the regex stuff to fix this issue @Alexays Added documentation in manpage and rebased on current master. |
|
Thx! ❤️ |
|
@Alexays done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites window title according to config option "rewrite".
"rewrite" is an object where keys are regular expressions and values are rewrite rules if the expression matches. Rules may contain references to captures of the expression. Regex and replacement follow ECMA-script rules. If no regex matches, the title is left unchanged.
Useful to add icons depending on the window title, e.g.:
Examples: