fix: schedule output destruction on idle callback #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed, I'll keep you posted! Thank you so much! |
|
I haven't seen a single crash in 4 days. I guess that fixed it. |
Defer destruction of bars for the output to the next iteration of the event loop to avoid deleting objects referenced by currently executed code.
alebastr
force-pushed
the
deferred-output-removal
branch
from
06dc2a8
to
943ba3a
Compare
|
Nice, thanks a lot! |
Alexays
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer destruction of bars for the output to the next iteration of the event loop to avoid deleting objects referenced by currently executed code.
Should fix some of the crashes on output disconnect. Could potentially cause a different kind of race conditions, but I haven't found anything that may happen in practice.
Testing: I've been running this patch for a week and attempting to reproduce the crash. Seems good so far.
@baloo, can you please try the patch and test if it fixes the issues in your setup?
Fixes #1019