Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when scrolling mouse over FFT and waterfall. #1367

Closed
fksms opened this issue Mar 29, 2024 · 1 comment
Closed

Crash when scrolling mouse over FFT and waterfall. #1367

fksms opened this issue Mar 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@fksms
Copy link

fksms commented Mar 29, 2024

Hardware

  • CPU: Apple M1
  • RAM: 8GB
  • GPU:
  • SDR: USRP B210

Software

  • Operating System: MacOS 14.4.1
  • SDR++: Nightly Build (currently 1.1.0)

Bug Description
Crash when scrolling mouse over FFT and waterfall.

The crash report is below.

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000028
Exception Codes: 0x0000000000000001, 0x0000000000000028

Termination Reason: Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process: exc handler [5819]

VM Region Info: 0x28 is not in any region. Bytes before following region: 4342415320
REGION TYPE START - END [ VSIZE] PRT/MAX SHRMOD REGION DETAIL
UNUSED SPACE AT START
--->
__TEXT 102d40000-102d44000 [ 16K] r-x/r-x SM=COW /Applications/SDR++.app/Contents/MacOS/sdrpp

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsdrpp_core.dylib 0x103411820 MainWindow::draw() + 8408
1 libsdrpp_core.dylib 0x103411820 MainWindow::draw() + 8408
2 libsdrpp_core.dylib 0x1034fdc70 backend::renderLoop() + 1840
3 libsdrpp_core.dylib 0x1033e78a8 sdrpp_main(int, char**) + 28644
4 dyld 0x18252a0e0 start + 2360

Additional info

The application crashes because if(vfo != null) is missing in the following part.
It looks like you are assigning an undefined value.
After modifying the code, the crash no longer occurs.

if (ImGui::IsKeyDown(ImGuiKey_LeftShift)) {
interval = vfo->snapInterval * 10.0;
}
else if (ImGui::IsKeyDown(ImGuiKey_LeftAlt)) {
interval = vfo->snapInterval * 0.1;
}
else {
interval = vfo->snapInterval;
}

I will submit a pull request if needed.

@fksms fksms added the bug Something isn't working label Mar 29, 2024
@AlexandreRouma
Copy link
Owner

Fixed

Ahmad-Bamba pushed a commit to Ahmad-Bamba/SDRPlusPlus that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants