Skip to content

Commit

Permalink
[mri_violations] Update module TestPlan and Readme
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexandraLivadas committed Feb 29, 2024
1 parent 819614c commit 8bf637b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
4 changes: 2 additions & 2 deletions modules/mri_violations/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,5 +80,5 @@ the problem "Could not identify scan type"

## Dashboard Widget

The total `Violated scans` will be shown inside the Dashboard widget, named "My Tasks"
with a link pointing to the mri_violations module.
The total number of unresolved `Violated scans` will be shown inside the Dashboard widget, named "My Tasks"
with a link pointing to the mri_violations module with the Resolution Status filter set to "Unresolved".
17 changes: 10 additions & 7 deletions modules/mri_violations/test/TestPlan.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,31 @@
with details of why the scan failed.
3. The `Problem` column with the entry `Could not identify scan type` should
display a popup with details of why the scan type could not be identified.
4. Go back to the MRI violations menu filter page and resolve issues with each of the
4. The `Image File` column should have a link to
the correct violated scan in the Brainbrowser module. Check that this link
works and takes you to the Brainbrowser module.
5. Go back to the MRI violations menu filter page and resolve issues with each of the
different types of resolutions. Once the page is refreshed, ensure the proper
resolution was set in column `Resolution Status`.
5. Click on the question mark on the right upper side of the windows and ensure
6. Click on the question mark on the right upper side of the windows and ensure
that the help content about MRI Violation is showing up and is up-to-date.
6. Ensure user has access to this page if and only if he/she has either permission
7. Ensure user has access to this page if and only if he/she has either permission
`mri_violations_view_allsite` or `mri_violations_view_ownsite`.
7. Check that if the user only has the permission `mri_violations_view_ownsite`, he/she
8. Check that if the user only has the permission `mri_violations_view_ownsite`, he/she
is not allowed to see the violations associated to sites other than his/her
own.
8. Check that the violations for which the site is unknown can always be seen
9. Check that the violations for which the site is unknown can always be seen
no matter what permission the user has (violated_scans_view_allsite or
violated_scans_view_ownsite).


### Dashboard Widget - "My Tasks" for Violated scans
1. Ensure the total of Violated scans corresponds with the correct
number of rows inside the MRI Violations module.
number of rows inside the MRI Violations module where the Resolution Status is Unresolved.
2. Verify that either `violated_scans_view_allsites` or `violated_scans_view_ownsites` permissions
are necessary for the user to view the widget.
3. Click on the total number of Violated Scans and check if redirection
to the MRI Violation module succeeds.
to the MRI Violation module succeeds. The MRI Violations page should have the Resolution Status filter preset to "Unresolved".

## Functionality tested by automated testing
1. Ensure that the module loads only when a user has appropriate permissions.
Expand Down

0 comments on commit 8bf637b

Please sign in to comment.