Skip to content

Commit

Permalink
[currency] fix metrics export endpoint (open-telemetry#904)
Browse files Browse the repository at this point in the history
* export metrics endpoint to default config

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* export metrics endpoint to default config

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* export metrics endpoint to default config

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

---------

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Carter Socha <43380952+cartersocha@users.noreply.github.com>
  • Loading branch information
2 people authored and AlexanderWert committed Jul 24, 2023
1 parent 93ef675 commit 3b89c9a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ release.
([#880](https://github.com/open-telemetry/opentelemetry-demo/pull/880))
* [currencyservice] Fix OTel C++ build and update OTel version to 1.9.0
([#886](https://github.com/open-telemetry/opentelemetry-demo/pull/886))
* [currencyservice] Fix OTLP export to use default env vars
([#904](https://github.com/open-telemetry/opentelemetry-demo/pull/904))
* [featureflagservice] Bump OTP version to 26.0
([#903](https://github.com/open-telemetry/opentelemetry-demo/pull/903))

Expand Down
1 change: 0 additions & 1 deletion src/currencyservice/src/meter_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ namespace
otlp_exporter::OtlpGrpcMetricExporterOptions otlpOptions;

// Configuration via environment variable not supported yet
otlpOptions.endpoint = "otelcol:4317";
otlpOptions.aggregation_temporality = metric_sdk::AggregationTemporality::kDelta;
auto exporter = otlp_exporter::OtlpGrpcMetricExporterFactory::Create(otlpOptions);

Expand Down

0 comments on commit 3b89c9a

Please sign in to comment.