feat: cd to workspace folder before executing yapf #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to have yapf honor `.yapfignore` or `pyproject.toml` files, which it reads from the directory that it is executed in. With the change, the call to `yapf` also passes `.` as the target for formatting; otherwise, relative paths specified in the ignore patterns do not match against the absolute target path. This resolves AlexanderMelde#7. Signed-off-by: Ingo Müller <ingomueller@google.com>
|
Hi Ingo, |
AlexanderMelde
requested changes
Nov 26, 2024
Co-authored-by: Alexander Melde <2115644+AlexanderMelde@users.noreply.github.com>
Signed-off-by: Ingo Müller <ingomueller@google.com>
|
Good catches -- both changes applied. Thanks for the quick review! |
AlexanderMelde
approved these changes
Nov 26, 2024
|
Thank you, I added your changes to the v2.0 release! |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to have yapf honor
.yapfignoreorpyproject.tomlfiles, which it reads from the directory that it is executed in. With the change, the call toyapfalso passes.as the target for formatting; otherwise, relative paths specified in the ignore patterns do not match against the absolute target path.This resolves #7.